Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update q2-sample-classifier citation #140

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Conversation

nbokulich
Copy link
Member

No description provided.

Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but, do you want to fix the title capitalization while we are at it?

Co-Authored-By: nbokulich <nbokulich@gmail.com>
@nbokulich
Copy link
Member Author

thanks for committing that change @thermokarst ! LGTM.

@nbokulich nbokulich assigned thermokarst and unassigned nbokulich Apr 15, 2019
@thermokarst
Copy link
Contributor

Did that change work for you, @nbokulich? I am still seeing a capital Q, and, when I check in q2cli it looks like those extra curly braces have been stripped. @ebolyen, does the citations API do some sanitizing when loading bibtex entries?

Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super nitpicky @nbokulich, but all of your new lines have tabs, when the rest of the file use spaces. When you have whitespace highlighting on this looks pretty gross.... :puke:

@thermokarst thermokarst assigned nbokulich and unassigned thermokarst Apr 15, 2019
@nbokulich
Copy link
Member Author

Did that change work for you

I did not test... you sounded so sure so I just assumed your fix would work! I am seeing the same thing: the extra curly braces are missing when I check in the CLI.

all of your new lines have tabs

Nick's nits picked, see latest commit

@ebolyen
Copy link
Member

ebolyen commented Apr 15, 2019

Re: bibtex, it is technically not using your bibtex, but reading it to generate an object for that entry, and then it re-writes it as needed. That said, the curly braces should have worked... Perhaps the Biber engine has stronger rules on title-casing?

@thermokarst
Copy link
Contributor

it is technically not using your bibtex

Yep, I could've been more clear with my question, I wanted to know what kinds of transformations were being applied to the bibtex entry.

Based on my poking around, the offending config is this little bit. Looks like this is an outstanding TODO in the parser.

@thermokarst
Copy link
Contributor

@nbokulich, confirmed that the rendering of the title works fine when the parser stops stripping braces from the entries. Will merge as-is, but nothing will change on the docs side of things until the parser dependency is updated (or, we come up with another way to unicodify entries).

@thermokarst thermokarst merged commit c3f59a6 into qiime2:master Apr 15, 2019
@thermokarst
Copy link
Contributor

@nbokulich - can you add a note to the changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants