-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to artifact class registration #283
Conversation
* artifact_format is now directory_format * semantic types, rather than type expressions, are now registered to formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor comment.
This is still a draft, and it'll take a bit for our CI to flush the latest framework out, but I see no reason not to merge this soon.
from q2_types.tree import NewickFormat | ||
|
||
tree = TreeNode.read(StringIO( | ||
'(SEQUENCE1:0.000000003,SEQUENCE2:0.000000003);')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the root be trifurcating in this particular example, since that's the common-ish convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Or we can switch it to Phylogeny[Rooted]
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! I updated to Phylogeny[Rooted] and set this as ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gregcaporaso!
This pull request depends on qiime2/qiime2#655.
This makes changes to tests to:
directory_format
instead ofartifact_format
, thoughartifact_format
is still supported when callingPlugin.register_semantic_type_to_format
)In a development environment with the above
qiime2
branch installed, this can be tested as follows:Access descriptions of artifact classes
Generate data and render an import usage example