Refactor q2-types to avoid circular imports #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2024
ebolyen
force-pushed
the
Trial-type-refactor
branch
from
73d725d to
d1cb02d
Compare
This was referenced Jul 24, 2024
This was referenced Jul 25, 2024
|
This is going to wait until we have a working metagenome prepare and trial. |
|
Both trials have passed, so we should be good to go as soon as we can guarantee a prepare |
ebolyen
force-pushed
the
Trial-type-refactor
branch
from
5e0a3d3 to
e2e830e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each submodule gets two sides, the public and importable subpackage as before, and a new
_deferred_setupwhich is only accessed byplugin_setup.py. This allows implementations and subpackages to rely on other subpackages without invoking registration logic which invariable re-importsplugincausing the mess in the first place.Full integration tests are paired here:
qiime2/distributions#314
qiime2/distributions#315