Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only feature ids present in the table should be clustered #10

Closed
gregcaporaso opened this issue Sep 19, 2017 · 1 comment
Closed

only feature ids present in the table should be clustered #10

gregcaporaso opened this issue Sep 19, 2017 · 1 comment

Comments

@gregcaporaso
Copy link
Member

gregcaporaso commented Sep 19, 2017

I helped a collaborator run cluster-features after importing sequences and a biom table that were processed with a non-QIIME 2 pipeline, and we had the surprising result that the resulting FeatureData[Sequence] had more records in it than there were features in the FeatureTable. It turned out that the input FeatureData[Sequence] had sequences for features that had been filtered out of the input FeatureTable. We should probably raise an error if the set of feature ids isn't the same between the two inputs.

This is a bit of an edge case, so isn't really high priority (this will probably primarily be applied to FeatureTable and FeatureData[Sequence] artifacts that are generated through a QIIME 2 pipeline).

gregcaporaso added a commit to gregcaporaso/q2-vsearch that referenced this issue Sep 20, 2017
@gregcaporaso
Copy link
Member Author

Addressed in #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant