Migrate to py310 #14
Merged
Migrate to py310 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thank you! Do you think is worth trying to also add 3.11 or 3.12? |
|
I just did. Tests pass :-) |
antgonza
reviewed
Aug 26, 2025
| Programming Language :: Python :: 3.5 | ||
| Programming Language :: Python :: 3.6 | ||
| Programming Language :: Python :: 3.9 | ||
| Programming Language :: Python :: 3.10 |
antgonza
reviewed
Aug 26, 2025
Comment on lines
21
to
22
| Programming Language :: Python :: 3.5 | ||
| Programming Language :: Python :: 3.6 |
There was a problem hiding this comment.
Thank you for adding those, just to confirm, is it OK to leave these?
There was a problem hiding this comment.
If I recall correctly, older plugins (qp-deblur) still run on py3.5 - so we should not remove.
Unfortunately, the test framework breaks, as pytest is not available in this old py version. I suggest to NOT test, but keep these lines
There was a problem hiding this comment.
found a way to avoid running coverage reports for older py versions, while still executing tests :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found qiime2 to be a heavy dependency in e.g. qtp-biom. With "heavy", I refer to filesize or more precise image size, when putting the plugin into a container.
I therefore experiment with the new q2-tiny release to keep depending files smaller. This requires py3.10 - which is not yet supported by qiita-files.
This PR shall make qiita-files upwards compatible with py 3.10 - and adds according tests for py3.9 (current state) AND py3.10. With that, I also replace the deprecated nose with pytest for the github action.