New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tentative improvements to sample/prep info files #2751

Closed

2 tasks done

antgonza opened this issue Dec 7, 2018 · 0 comments

Closed

2 tasks done

Tentative improvements to sample/prep info files #2751

antgonza opened this issue Dec 7, 2018 · 0 comments

Labels

enhancement group input

Milestone

nice-to-have-dev

Member

antgonza commented Dec 7, 2018 •

edited

Loading

During the jsonb conversion we noticed a couple of things that could be nice to improve in the info files:

make sample/prep categories() a property
there is an "interesting" combination/duplication-of-code of Sample (one at the time) and SampleTemplate (multiple); for example categories and _get_categories

antgonza added this to the nice-to-have-dev milestone

antgonza mentioned this issue

Info files from str to jsonb #2743

Merged

adswafford added enhancement group input labels

antgonza added a commit to antgonza/qiita that referenced this issue


          fix qiita-spots#2751

e9feca6

antgonza closed this as completed in

8fb9ca0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment