Redbiom improving listing #2132
Conversation
| at.artifact_type_id = a.artifact_type_id | ||
| AND artifact_type = 'BIOM') | ||
| ORDER BY artifact_id | ||
| GROUP BY study_title, study_id, artifact_id), |
There was a problem hiding this comment.
would it be possible to get an english description of what this query does? inline comments within the query to describe the subqueries would also be helpful
There was a problem hiding this comment.
added some information.
| for row in qdbsc.TRN.execute_fetchindex(): | ||
| title, sid, samples, name, cid, aid = row | ||
| title, sid, samples, name, cid, aid, pp = row |
There was a problem hiding this comment.
I dont understand how the select on main_query did not change but somehow row has an additional element now?
There was a problem hiding this comment.
the with is basically a select after another select, this allows us to make faster queries and "work" with json ... hopefully the explanation added helps.
| # [0] then taking the first element that is | ||
| # the name of the parameter set | ||
| ppc = sorted( | ||
| [[k, len(eval(pp) & v)] |
There was a problem hiding this comment.
psql return a set as a string so we are eval that ..
| nr['command'] = commands[cid]['cmdn'] | ||
| nr['software'] = commands[cid]['sfwn'] | ||
| nr['version'] = commands[cid]['sfv'] | ||
| commands[cid] = '%s - %s v%s' % ( |
There was a problem hiding this comment.
should trim length be represented?
There was a problem hiding this comment.
it has it, in the next block the processing parameters of the parent are added.
There was a problem hiding this comment.
thanks, @wasade, I think my comemnts should help, please let me know otherwise. @ElDeveloper or @josenavas could you take a look?
| at.artifact_type_id = a.artifact_type_id | ||
| AND artifact_type = 'BIOM') | ||
| ORDER BY artifact_id | ||
| GROUP BY study_title, study_id, artifact_id), |
There was a problem hiding this comment.
added some information.
| for row in qdbsc.TRN.execute_fetchindex(): | ||
| title, sid, samples, name, cid, aid = row | ||
| title, sid, samples, name, cid, aid, pp = row |
There was a problem hiding this comment.
the with is basically a select after another select, this allows us to make faster queries and "work" with json ... hopefully the explanation added helps.
| nr['command'] = commands[cid]['cmdn'] | ||
| nr['software'] = commands[cid]['sfwn'] | ||
| nr['version'] = commands[cid]['sfv'] | ||
| commands[cid] = '%s - %s v%s' % ( |
There was a problem hiding this comment.
it has it, in the next block the processing parameters of the parent are added.
| # [0] then taking the first element that is | ||
| # the name of the parameter set | ||
| ppc = sorted( | ||
| [[k, len(eval(pp) & v)] |
There was a problem hiding this comment.
psql return a set as a string so we are eval that ..
There was a problem hiding this comment.
Just a question. Also, is it possible to put the dropdown choosing the processing parameters on top rather than on the bottom? It's location inside the table is not ideal, but I guess it will take too long to pull it out. Also just noticed that the label on the table filter "Filter results by column data (Study Name, Artifact Name, Software, etc):" is not synced with the actual column names.
| * gif to show that the section of page is loading | ||
| * | ||
| */ | ||
| function show_loading(div_name) { |
There was a problem hiding this comment.
Why is this function removed from here?
There was a problem hiding this comment.
In the previous PR, you requested to be moved here and I did. However, while working on this version I realized that it was a bad decision because it uses {% raw qiita_config.portal_dir %}, which it's not executed correctly as it's in the qiita.js file. Moved it sitebase.html so it works correctly.
| * gif to show that the section of page is loading | ||
| * | ||
| */ | ||
| function show_loading(div_name) { |
There was a problem hiding this comment.
In the previous PR, you requested to be moved here and I did. However, while working on this version I realized that it was a bad decision because it uses {% raw qiita_config.portal_dir %}, which it's not executed correctly as it's in the qiita.js file. Moved it sitebase.html so it works correctly.
| * gif to show that the section of page is loading | ||
| * | ||
| */ | ||
| function show_loading(div_name) { |
Changes based on discussion during our 05/10/17 meeting. Basically, we are grouping by parent (trim, split, etc).
Note that there are different ways to do this: (A) changes in the db so it's "easy" to retrieve the default setting name from parents or any artifact, (B) do the matching in SQL or (C) python. (A) will need a lot of changes to the code and the db, and we will need B or C to make it happen as we will need to populate all current artifacts. Thus, decided that (B) or (C) were the option. Started with (B) and realized that all json operation in postgres (the processing parameters are stored as json) are not easy (or even possible) in any version below 9.4; in fact, greater of 9.5 will make life easier; our servers have 9.3. Even so, tried this way and the query was taking around 12 seconds from the 'infant' test (it originally took ~500ms) so discarded that version. Thus, implemented (C) and it's the one in this PR ('infant' test takes ~1s, not terrible).
Will deploy in the test environment in a few minutes.