Skip to content

Improving artifact info and study listing #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented Jun 18, 2017

Based on #2147 so review that one first (note that it's also in WIP so don't review anything 😄 ).

@ElDeveloper
Copy link
Contributor

👍

Copy link
Contributor

@josenavas josenavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once tests pass

@codecov-io
Copy link

codecov-io commented Jul 4, 2017

Codecov Report

Merging #2149 into analysis-refactor will decrease coverage by 0.01%.
The diff coverage is 97.22%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           analysis-refactor    #2149      +/-   ##
=====================================================
- Coverage              92.06%   92.04%   -0.02%     
=====================================================
  Files                    188      188              
  Lines                  19474    19508      +34     
=====================================================
+ Hits                   17928    17957      +29     
- Misses                  1546     1551       +5
Impacted Files Coverage Δ
qiita_pet/handlers/api_proxy/__init__.py 100% <ø> (ø) ⬆️
qiita_pet/handlers/study_handlers/__init__.py 100% <ø> (ø) ⬆️
qiita_pet/webserver.py 100% <ø> (ø) ⬆️
...lers/study_handlers/tests/test_listing_handlers.py 99.3% <ø> (-0.01%) ⬇️
...pet/handlers/study_handlers/tests/test_artifact.py 97.08% <100%> (+0.21%) ⬆️
qiita_pet/handlers/api_proxy/artifact.py 99.2% <100%> (+0.02%) ⬆️
...iita_pet/handlers/api_proxy/tests/test_artifact.py 98.19% <100%> (+0.05%) ⬆️
qiita_db/test/test_util.py 99.78% <100%> (ø) ⬆️
qiita_pet/handlers/study_handlers/artifact.py 95.38% <100%> (+0.38%) ⬆️
qiita_db/util.py 96.49% <95.34%> (-0.37%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c91753...b114500. Read the comment docs.

@antgonza antgonza changed the title WIP: Improving artifact info and study listing Improving artifact info and study listing Jul 7, 2017
@josenavas josenavas merged commit ab0e2f2 into qiita-spots:analysis-refactor Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants