Skip to content

Fix 2210 #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 21, 2017
Merged

Fix 2210 #2246

merged 7 commits into from
Aug 21, 2017

Conversation

antgonza
Copy link
Member

Adds sample counts by prep in the listing. Deciding to go via PrepTemplate.keys() cause it and cache the values as it saves us some code/queries.

Now, the study list looks like this:
study_list

The study/sample selected like this:
selected

Copy link
Contributor

@josenavas josenavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given test pass

@codecov-io
Copy link

codecov-io commented Aug 21, 2017

Codecov Report

Merging #2246 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2246      +/-   ##
==========================================
+ Coverage   92.81%   92.81%   +<.01%     
==========================================
  Files         171      171              
  Lines       18906    18917      +11     
==========================================
+ Hits        17547    17558      +11     
  Misses       1359     1359
Impacted Files Coverage Δ
qiita_db/util.py 96.55% <100%> (+0.03%) ⬆️
...iita_pet/handlers/api_proxy/tests/test_artifact.py 98.22% <100%> (+0.03%) ⬆️
...pet/handlers/study_handlers/tests/test_artifact.py 97.19% <100%> (+0.1%) ⬆️
qiita_db/test/test_util.py 99.78% <100%> (ø) ⬆️
qiita_db/metadata_template/util.py 90.97% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a369cad...b7e2cc9. Read the comment docs.

@tanaes tanaes merged commit f94af55 into qiita-spots:dev Aug 21, 2017
@josenavas
Copy link
Contributor

Thanks @tanaes 🍺

@tanaes
Copy link
Contributor

tanaes commented Aug 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants