-
Notifications
You must be signed in to change notification settings - Fork 80
Fix 2210 #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2210 #2246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given test pass
Codecov Report
@@ Coverage Diff @@
## dev #2246 +/- ##
==========================================
+ Coverage 92.81% 92.81% +<.01%
==========================================
Files 171 171
Lines 18906 18917 +11
==========================================
+ Hits 17547 17558 +11
Misses 1359 1359
Continue to review full report at Codecov.
|
Thanks @tanaes 🍺 |
I inevitably make a bunch of 'wait I don't understand why...' comments on
these PRs but then spend a bunch of time scrolling back and forth on the
diffs and then I'm like 'ahhh oh I see.' :P
…On Mon, Aug 21, 2017 at 12:44 PM Jose Navas ***@***.***> wrote:
Thanks @tanaes <https://github.com/tanaes> 🍺
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2246 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AH6JALYCVOGewXeQ5mKydElF6iFl0eZsks5sad4rgaJpZM4O8w75>
.
|
Adds sample counts by prep in the listing. Deciding to go via PrepTemplate.keys() cause it and cache the values as it saves us some code/queries.
Now, the study list looks like this:

The study/sample selected like this:
