Skip to content

Remove moi #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Sep 11, 2017
Merged

Remove moi #2260

merged 53 commits into from
Sep 11, 2017

Conversation

josenavas
Copy link
Contributor

@josenavas josenavas commented Aug 31, 2017

This is the list of tasks that need to be completed before this can be merged:

In the list above, everything that needs to be moved to the Qiita internal plugin requires add a new command to the Qiita internal plugin and update the interface bits to look for a ProcessingJob rather than a moi job in redis

@codecov-io
Copy link

codecov-io commented Aug 31, 2017

Codecov Report

Merging #2260 into dev will increase coverage by 15.42%.
The diff coverage is 85.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev    #2260       +/-   ##
===========================================
+ Coverage   78.36%   93.78%   +15.42%     
===========================================
  Files           9      161      +152     
  Lines         550    18249    +17699     
===========================================
+ Hits          431    17115    +16684     
- Misses        119     1134     +1015
Impacted Files Coverage Δ
qiita_db/__init__.py 100% <ø> (ø)
qiita_db/test/test_commands.py 99.6% <ø> (ø)
qiita_pet/test/test_prep_template.py 97.87% <ø> (ø)
qiita_db/commands.py 96.55% <ø> (ø)
qiita_db/handlers/tests/test_oauth2.py 99.34% <100%> (ø)
qiita_pet/test/test_user_handlers.py 96.96% <100%> (ø)
...t/handlers/api_proxy/tests/test_sample_template.py 98.55% <100%> (ø)
qiita_pet/test/rest/test_base.py 100% <100%> (ø)
...ta_pet/handlers/artifact_handlers/base_handlers.py 93.29% <100%> (ø)
qiita_db/handlers/processing_job.py 96.92% <100%> (ø)
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8d271...4ed9285. Read the comment docs.

josenavas and others added 21 commits August 31, 2017 15:51
* Move qiita_db/private.py -> qiita_ware/private_plugin.py

* Transferring VAMPS submission to internal job

* Fixing import
* Move qiita_db/private.py -> qiita_ware/private_plugin.py

* Transferring VAMPS submission to internal job

* Fixing merge conflicts

* Adding tests to private plugin

* Removing import

* Fixing import

* Modifying GUI to use the plugin

* Adding success test
* Moving update_sample_template

* Transfer update_sample_template

* Porting update prep template

* Moving delete sample or column

* Removing tests

* Removing dispatchable and its tests

* Updating interface to use the new functionality'

* Adapting the prep template GUI

* Submitting jobs

* Fixing tests

* Removing qiita_ware/context.py

* flake8ing

* Fixing _system_call

* Safeguarding the call to rollback

* Unmasking more errors

* Forcing different connections on different processes

* Moving job completion to internal plugin structure

* Removing unused code

* Forcing the creation of a new transaction on the jobs

* Fixing tests

* forcing the commit

* Fixing all tests

* Addressing @antgonza's comments

* Addressing @antgonza's comment

* Addressing @ElDeveloper's comments
* Fixing the redis DB

* Addressing @antgonza's comments
@antgonza antgonza mentioned this pull request Sep 10, 2017
@antgonza antgonza changed the title [WIP] Remove moi Remove moi Sep 11, 2017
@josenavas josenavas merged commit 45e0175 into dev Sep 11, 2017
@josenavas josenavas deleted the remove-moi branch September 15, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants