-
Notifications
You must be signed in to change notification settings - Fork 80
Remove moi #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove moi #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrading software
r_client to qiita
Codecov Report
@@ Coverage Diff @@
## dev #2260 +/- ##
===========================================
+ Coverage 78.36% 93.78% +15.42%
===========================================
Files 9 161 +152
Lines 550 18249 +17699
===========================================
+ Hits 431 17115 +16684
- Misses 119 1134 +1015
Continue to review full report at Codecov.
|
rm moi and ipython
…ansfer-copy-raw-data
rm create raw data
* Move qiita_db/private.py -> qiita_ware/private_plugin.py * Transferring VAMPS submission to internal job * Fixing import
rm wrapper.py
…ansfer-copy-raw-data
* Move qiita_db/private.py -> qiita_ware/private_plugin.py * Transferring VAMPS submission to internal job * Fixing merge conflicts * Adding tests to private plugin * Removing import * Fixing import * Modifying GUI to use the plugin * Adding success test
mv some methods
* Moving update_sample_template * Transfer update_sample_template * Porting update prep template * Moving delete sample or column * Removing tests * Removing dispatchable and its tests * Updating interface to use the new functionality' * Adapting the prep template GUI * Submitting jobs * Fixing tests * Removing qiita_ware/context.py * flake8ing * Fixing _system_call * Safeguarding the call to rollback * Unmasking more errors * Forcing different connections on different processes * Moving job completion to internal plugin structure * Removing unused code * Forcing the creation of a new transaction on the jobs * Fixing tests * forcing the commit * Fixing all tests * Addressing @antgonza's comments * Addressing @antgonza's comment * Addressing @ElDeveloper's comments
* Fixing the redis DB * Addressing @antgonza's comments
Merged
mv moi-ws to qiita_websocket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the list of tasks that need to be completed before this can be merged:
submit_to_EBI
to Qiita internal "plugin" @antgonza mv some methods #2268submit_to_VAMPS
to Qiita internal "plugin" @josenavas Transfer submit to vamps #2265create_raw_data
fromqiita_ware/dispatchable.py
since it is not used anywhere @antgonza rm create raw data #2264copy_raw_data
to Qiita internal "plugin" @josenavas Transfer copy raw data #2267delete_artifact
to Qiita internal "plugin" @antgonza mv some methods #2268create_sample_template
to Qiita internal "plugin" @antgonza mv some methods #2268update_sample_template
to Qiita internal "plugin" @josenavas Transfer update delete templates #2274delete_sample_template
to Qiita internal "plugin" @josenavas Transfer update delete templates #2274update_prep_template
to Qiita internal "plugin" @josenavas Transfer update delete templates #2274delete_sample_or_column
to Qiita internal "plugin" @josenavas Transfer update delete templates #2274qiita_ware/dispatchable.py
Transfer update delete templates #2274qiita_ware/context.py
Transfer update delete templates #2274qiita_ware/executor.py
@antgonza rm create raw data #2264per_sample_sequences
fromqiita_ware/util.py
since it is not used anywhere @antgonza rm create raw data #2264qiita_ware/wrapper.py
@antgonza rm wrapper.py #2266qiita_core/configuration_manager.py
to remove the ipython configuration @antgonza: rm moi and ipython #2263setup.py
and.travis.yml
@antgonza: rm moi and ipython #2263qiita_test_install
to not check for ipython (is no longer a Qiita dependency) @antgonza: rm moi and ipython #2263In the list above, everything that needs to be moved to the Qiita internal plugin requires add a new command to the Qiita internal plugin and update the interface bits to look for a ProcessingJob rather than a moi job in redis