Skip to content

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented Dec 6, 2018

#2743 should be reviewed/merged first

@antgonza antgonza changed the base branch from master to dev December 6, 2018 21:42
@antgonza antgonza changed the title Sample generate files improvements WIP: sample generate files improvements Dec 6, 2018
@antgonza antgonza changed the title WIP: sample generate files improvements Sample generate files improvements Dec 11, 2018
Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request response to comments, before approving; changes not needed if you feel that it is fine.

"DB and the new data provided",
qdb.exceptions.QiitaDBWarning)
return
return set([]), set([])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to return two empty sets vs None, or (None, None), throw an Exception, etc?

md_template, self.study_id, current_columns=self.categories())
self._update(new_map)
samples, columns = self._update(new_map)
self.validate(self.columns_restrictions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like it'd be more readable to test for not None or similar here, instead of having to go down into validate(), but I defer.

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #2749 into dev will increase coverage by 4.68%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #2749      +/-   ##
=========================================
+ Coverage   89.62%   94.3%   +4.68%     
=========================================
  Files          93     166      +73     
  Lines        6459   19980   +13521     
=========================================
+ Hits         5789   18843   +13054     
- Misses        670    1137     +467
Impacted Files Coverage Δ
qiita_db/metadata_template/prep_template.py 97.96% <100%> (ø)
qiita_db/metadata_template/sample_template.py 100% <100%> (ø)
...ita_db/metadata_template/base_metadata_template.py 95.51% <91.3%> (ø)
qiita_db/test/test_artifact.py 99.85% <0%> (ø)
qiita_db/metadata_template/__init__.py 100% <0%> (ø)
qiita_db/handlers/tests/test_prep_template.py 98.5% <0%> (ø)
qiita_db/test/test_logger.py 97.22% <0%> (ø)
qiita_db/handlers/tests/test_user.py 96.66% <0%> (ø)
qiita_db/test/test_software.py 99.82% <0%> (ø)
qiita_db/test/test_study.py 99.77% <0%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b353b33...1005f85. Read the comment docs.

@charles-cowart charles-cowart merged commit fdcbfe3 into qiita-spots:dev Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants