WIP: adding admin direct job creation #3140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElDeveloper
reviewed
Sep 8, 2021
* WIP: Add first version of jobs table Does not autoupdate and the UI could be better. * ENH: Working version of the UI * ENH: Better working version of the table * ERR: Undo changes to nginx file * ERR: More ctrl-z * ENH: Improve column widths * TST: Add first round of tests * TST: Add more tests * TST: Add a check for the correct payload * ENH: Fix minor issues * ENH: Address @antgonza's review comments
charles-cowart
approved these changes
Sep 13, 2021
Contributor
charles-cowart
left a comment
charles-cowart
left a comment
There was a problem hiding this comment.
Looks good. Nothing looks out of place.
charles-cowart
approved these changes
Sep 13, 2021
Contributor
charles-cowart
left a comment
charles-cowart
left a comment
There was a problem hiding this comment.
Looks good. Nothing looks out of place. Code coverage went down very slightly. @antgonza @ElDeveloper @charles-cowart looked over the changes and found it acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.