add qiita_db/studies/ endpoint #3154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasade
reviewed
Oct 14, 2021
qiita_db/handlers/studies.py
Outdated
|
|
||
| sql = f""" | ||
| SELECT study_id, array_agg(DISTINCT artifact_id) FROM qiita.study | ||
| LEFT JOIN qiita.study_artifact USING (study_id) |
There was a problem hiding this comment.
Why left not inner? Would this create a possibility where artifact_id is null in the aggregation?
There was a problem hiding this comment.
Good question, I think it should be fine but I'll change just to be sure.
antgonza
commented
Oct 14, 2021
qiita_db/handlers/studies.py
Outdated
|
|
||
| sql = f""" | ||
| SELECT study_id, array_agg(DISTINCT artifact_id) FROM qiita.study | ||
| LEFT JOIN qiita.study_artifact USING (study_id) |
There was a problem hiding this comment.
Good question, I think it should be fine but I'll change just to be sure.
|
@wasade, tests are passing so it should be ready to merge; thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.