Skip to content

Some general cleaning and getting things in place to fix #3091 #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

antgonza
Copy link
Member

First review/merge: #3163

@coveralls
Copy link

coveralls commented Nov 18, 2021

Coverage Status

coverage: 91.08% (+0.001%) from 91.079%
when pulling a78712d on antgonza:fix-3091
into 16af20e on qiita-spots:dev.

@antgonza antgonza changed the title [WIP] Fix 3091 Some general cleaning and getting things in place to fix #3091 Nov 19, 2021
@antgonza
Copy link
Member Author

@wasade once the test pass, this should be ready to be reviewed; thank you. Note that this could solve #3091 but don't think is worth deploying as explained here but I think the general improvement and having the lines commented out is a good way forward; please let me know what you think.

@antgonza
Copy link
Member Author

antgonza commented Feb 1, 2022

@wasade; could you review/merge when you get a second? Thank you.

@wasade
Copy link
Contributor

wasade commented Feb 1, 2022

I don't really understand the context and am not really familiar with the surrounding code. Given that, I don't see anything weird

@antgonza
Copy link
Member Author

antgonza commented Feb 1, 2022

ha! yes, it has been almost 3 months since we worked on this but I guess that's good enough ... thank you, I'll merge it!

@antgonza antgonza merged commit cd1dbeb into qiita-spots:dev Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants