Skip to content

Fix #3249 #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2023
Merged

Fix #3249 #3263

merged 2 commits into from
Mar 7, 2023

Conversation

charles-cowart
Copy link
Contributor

No description provided.

@charles-cowart charles-cowart requested a review from antgonza March 4, 2023 04:03
@charles-cowart
Copy link
Contributor Author

I'm not an expert at Javascript, but it appears that the original string from linkFormatter was itself good. I was able to host the element inside an alert message and the toggle function was reached. It appears that SlickGrid did not like an attribute named 'onchanged'. In fact, it doesn't seem to like any any attribute starting with 'on'. Inside the inspector, you could see that all of the other attributes were loaded into the DOM correctly, but the value of 'onchanged' was there by itself, without a key. If I manually set a key for the value, everything worked as intended.

Eventually I opted to use SlickGrid's own event handler and that seemed to work well.

antgonza
antgonza requested changes Mar 5, 2023
View reviewed changes
Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @charles-cowart! Note that during testing I noticed that the check-all toggle doesn't work; see:
3263

Could you also fix?

@charles-cowart
Bugfixes
afe8d9c 
Fixed select-all checkbox so that it works properly.
Fixed it so that when a user clicks inside checkbox cell, but not
checkbox itself, it toggles status.
@charles-cowart
Copy link
Contributor Author

@antgonza ready for review.

antgonza
antgonza approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@antgonza antgonza merged commit 4712985 into qiita-spots:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgonza antgonza antgonza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charles-cowart @antgonza