-
Notifications
You must be signed in to change notification settings - Fork 79
initial database setup for travis #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Readme updates
Distutils
added automatic python 2to3 conversion
added a mongodb+postgres prototype
Unify all the repositories
Makes code easier to read, updated some comments and docstrings, makes all column names lowercase, changes varchar type to NOT have a length limit
Also some other comments from @wasade
Add pronunciation hint to the README.md file.
Important documentation fix
Initial checkin of PostgreSQL prototype
Pyqi port
This PR is ready to review (yay!!) The additions included in this PR are:
Although there are 27 files modifies, a lot of them are the sql files and the placeholder files for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issue here, just want to say this is a bad ass way of setting this up.
Also, you can safely ignore checking the qiita-db.html and qiita-db.dbs files. They are auto-generated saves from DbSchema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this file change-of-name is just git weirdness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAY!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cogent?
On May 22, 2014 8:16 AM, "teravest" notifications@github.com wrote:
In .travis.yml:
@@ -3,12 +3,9 @@ python:
- "2.7"
install:
- pip install numpy
- pip install cogent
YAY!
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/52/files#r12955383
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahaha, yup, it was there... removing cogent speeded-up the travis runs 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all these checks -- I think this should be plenty enough to make sure people don't accidentally blow away their database! They'd really have to intentionally screw up three things simultaneously (I think)
I think I've addressed all your comment. Let me know if I missed something! |
qiita_db/make_environment.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these, it could be a nice use of functools.partial
to do something like:
get_support_file = partial(join, join(dirname(abspath(__file__)), 'support_files'))
DFLT_BASE_DATA_FOLDER = get_support_file('test_data')
SETTINGS_FP = get_support_file('qiita-db-settings.sql')
LAYOUT_FP = get_support_file('qiita-db.sql')
INITIALIZE_FP = get_support_file('initialize.sql')
POPULATE_FP = get_support_file('populate_test_db.sql')
👍 |
initial database setup for travis
Thank you all for the comments! and thanks @squirrelo for the help to get this done! |
Fixes #50