improve summary #41
Merged
improve summary #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cowart
suggested changes
Jun 23, 2022
| @@ -115,7 +129,7 @@ def test_validate_multiple_error(self): | |||
| "1.SKB3.640195": {"run_prefix": "prefix2"}} | |||
| files = {'Unknown': ['/path/to/file1.fastq']} | |||
| atype = "FASTQ" | |||
| job_id = self._create_template_and_job(prep_info, files, atype) | |||
| job_id, _ = self._create_template_and_job(prep_info, files, atype) | |||
There was a problem hiding this comment.
@antgonza Don't you think that parameters should be checked as well, now that they're being returned? It seems like this function is only getting half-tested.
There was a problem hiding this comment.
Do you mean _create_template_and_job? If yes, that's a test help method to avoid duplication of code; thus not really needed to be tested; in other words, we normally don't write tests for the tests. If not, which function are you talking about?
There was a problem hiding this comment.
Ah I see. Yes, that's the one.
charles-cowart
approved these changes
Jun 23, 2022
This was referenced Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.