Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added qltui in setup.py #1354

Merged
merged 1 commit into from
May 29, 2023
Merged

Added qltui in setup.py #1354

merged 1 commit into from
May 29, 2023

Conversation

river-li
Copy link
Contributor

When using pip install qiling, the qltui.py is not copied to the site-packages folder.

Running qltool qltui would get a No module found error.

(test) ➜  qiling git:(master) qltool qltui
Traceback (most recent call last):
  File "/Users/river/.virtualenvs/test/bin/qltool", line 232, in <module>
    import qltui
ModuleNotFoundError: No module named 'qltui'

Added qltui.py in setup.py.

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@kabeor
Copy link
Member

kabeor commented May 29, 2023

Thanks a lot! Merged.

@kabeor kabeor merged commit 1706049 into qilingframework:dev May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants