Support additional operation queuing #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds more operation queuing that supports X, Y, Z, S, Sadj, T, and Tadj (along with controls) when feasible. When flushed, the queue will apply each of these operations in one iteration through the state vector rather than iterating the state vector for each. In practice, this seems to provide small benefits for programs will few qubits and thus small vectors (6% to 7%) but the benefit scales with the size of the state vector (observed 23% to 50% on larger programs).
idavis
reviewed
Jul 2, 2024
idavis
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more operation queuing that supports X, Y, Z, S, Sadj, T, and Tadj (along with controls) when feasible. When flushed, the queue will apply each of these operations in one iteration through the state vector rather than iterating the state vector for each. In practice, this seems to provide small benefits for programs will few qubits and thus small vectors (6% to 7%) but the benefit scales with the size of the state vector (observed 23% to 50% on larger programs).
This helps address feedback on perf, fixes #188