This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Allow the encoding to be generated on the fly in solve()
#13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9.
Details and comments
Remaining tasks:
self.encoding.offsetinsolve().offsetsomehow needs to make it fromsolve_relaxed()tosolve(). It seems likesolve_relaxed()almost needs to return theoffsetas a third tuple element ... or, we could put it in theRoundingContext, but it doesn't seem to really belong there. Potentially related to Provide access to rounding post-processing as a method #8. Possible solution in Deprecateencoding.offsetwhile incorporating it intoencoding.qubit_op#14.