Update ignore for latest mypy #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
added
the
stable backport potential
Pull Request Test Coverage Report for Build 10020768798Details
💛 - Coveralls |
|
This is just failing tests with main now, as expected, which #188 is done to correct |
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
(cherry picked from commit bf5e903)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nightly CI is failing following mypy 1.11 release. It seems that the detected error is now different. I changed things to be compatible with the prior version which ends up with two ignores and and unused ignore with each so that the other version does not raise the specific error does not raise another about it being unused.
What with all the suppression there now I can't help but think the code ought to be fixed in some way. But for now it works, i.e. passes unit tests etc. so this simply updates things for CI to pass too.
Details and comments