Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used trusted publisher for PyPi #88

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Used trusted publisher for PyPi #88

merged 2 commits into from
Oct 19, 2023

Conversation

woodsp-ibm
Copy link
Member

Summary

This PR follows Qiskit/rustworkx#1001 to update the release CI workflow to use PyPI's trusted publisher mechanism.

Details and comments

@woodsp-ibm woodsp-ibm added the on hold Can not fix yet label Oct 12, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6536279817

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.526%
Totals Coverage Status
Change from base Build 6531179342: 0.0%
Covered Lines: 6450
Relevant Lines: 7125
💛 - Coveralls

mtreinish
mtreinish approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I'm planning to hopefully migrate the pypi account on Wednesday, so as long as you aren't planning any releases before then we can merge this whenever (it only will work after the migration though).

@woodsp-ibm woodsp-ibm added automerge and removed on hold Can not fix yet labels Oct 18, 2023
@ElePT ElePT merged commit 1062753 into qiskit-community:main Oct 19, 2023
@woodsp-ibm woodsp-ibm deleted the pypi branch October 19, 2023 12:34
@ElePT
Copy link
Collaborator

ElePT commented Jan 19, 2024

@Mergifyio backport stable/0.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 19, 2024 •
edited
Loading

backport stable/0.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 19, 2024
@woodsp-ibm @mergify
Used trusted publisher for PyPi (#88)
83314a8 
(cherry picked from commit 1062753)
@mergify mergify bot mentioned this pull request Jan 19, 2024
Merged
ElePT pushed a commit that referenced this pull request Jan 19, 2024
@mergify @woodsp-ibm
Used trusted publisher for PyPi (backport #88) (#134)
07f14e3 
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

@mtreinish mtreinish mtreinish approved these changes

@Cryoris Cryoris Awaiting requested review from Cryoris Cryoris is a code owner

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woodsp-ibm @coveralls @ElePT @mtreinish