Setup tach. Enfore isolation of api_client

qiskit-community · Nov 20, 2024 · 7b118c6 · 7b118c6
1 parent 6ba4c9e
commit 7b118c6
Show file tree

Hide file tree

Showing 6 changed files with 250 additions and 2 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -33,6 +33,12 @@ repos:
       - id: interrogate
         args: [-v, qiskit_aqt_provider, test]
         pass_filenames: false  # needed if excluding files with pyproject.toml or setup.cfg
+  - repo: https://github.com/airwoodix/tach-pre-commit
+    rev: "v0.14.3-external"
+    hooks:
+      - id: tach
+      - id: tach-external
+        args: ["-e", "test/"]
   - repo: local
     hooks:
       - id: check-api-models

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 * Fix source installation problem caused by removed debugpy 1.8.3 package (#188)
 * User guide: add section on direct-access resources (#191)
+* Split Qiskit-agnostic client resources to separate sub-package (#198)
 
 ## qiskit-aqt-provider v1.8.1
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -58,6 +58,7 @@ pytest_qiskit_aqt = "qiskit_aqt_provider.test.fixtures"
 [tool.poetry.dependencies]
 python = ">=3.9,<3.13"
 
+annotated-types = ">=0.7.0"
 httpx = ">=0.24.0"
 platformdirs = ">=3"
 pydantic = ">=2.5.0"
@@ -100,6 +101,7 @@ rich = "^13.5.3"
 ruff = "^0.7.0"
 sphinx = ">=7,<7.3"
 sphinx-toolbox = "^3.5.0"
+tach = "^0.14.3"
 tomlkit = "^0.13.2"
 typer = "^0.13.0"
 types-requests = "^2.28.11"
@@ -313,13 +315,23 @@ shell = "interrogate -v qiskit_aqt_provider test"
 [tool.poe.tasks.spellcheck]
 shell = "typos ."
 
+[tool.poe.tasks.check_internal_dependencies]
+shell = "tach check"
+
+[tool.poe.tasks.check_external_dependencies]
+# Exclude the test module because tach doesn't collect
+# dependencies outside the main group.
+shell = "tach check-external -e test/"
+
 [tool.poe.tasks]
 lint = [
   "check_pre_commit_consistency",
   "check_api_models",
   "docstring_coverage",
   "ruff_check",
   "spellcheck",
+  "check_internal_dependencies",
+  "check_external_dependencies",
 ]
 format_check = [
   "python_format_check",

diff --git a/scripts/check_pre_commit_consistency.sh b/scripts/check_pre_commit_consistency.sh
@@ -19,6 +19,7 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 readonly SCRIPT_DIR
 
 # Tools to check.
+# FIXME: add tach when using upstream tag again
 TOOLS=(ruff typos pyproject-fmt interrogate)
 readonly TOOLS