Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

VQE construct_circuit does not return a circuit #1019

Closed
woodsp-ibm opened this issue May 28, 2020 · 1 comment · Fixed by #1121
Closed

VQE construct_circuit does not return a circuit #1019

woodsp-ibm opened this issue May 28, 2020 · 1 comment · Fixed by #1121

Comments

@woodsp-ibm
Copy link
Member

Prior to 0.7 the VQE construct_circuit, like the same method in other algorithms, would supply back the circuit the algorithm would running - now parameters or other information might be needed for a variational or iterative algo, but it was a circuit. People are interested in viewing and understanding the circuits the algos are using. None more so than VQE.

In 0.7 construct_circuit is returning an opflow construction. Now while its fine to have that available as well (via a more appropriately name method) it would be nice to have the actual circuit from the construct_circuit method available as was available in the past.

@molar-volume
Copy link
Contributor

molar-volume commented Jun 7, 2020

Hello @woodsp-ibm ,
I am working on it.
I renamed it 'construct_observable_measurement' and created new implementation of 'construct_circuit' that returns a circuit and is called inside 'construct_observable_measurement'.

molar-volume added a commit to molar-volume/qiskit-aqua that referenced this issue Jun 18, 2020
1) original construct_circuit method is renamed to construct_observable_measurement
2) new implementation of construct_circuit, that returns the actual circuit, and is called as part of the construct_observable_measurement procedure
@pbark pbark added this to the 0.8 milestone Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants