This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
VQE construct circuit returns circuits #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
changed the title
|
|
|
Manoel Marques seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
woodsp-ibm
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Looks good. An enhancement whereby the basis change and measurement gates are appended in a named block including that includes the Pauli string/group label for ease of identification of cct correspondence to the operator paulis, as we had in the past would be nice. But this can be done in a separate PR since it really changes only the visualization of the circuits not the circuits themselves.
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
* VQE construct circuit to return circuits * add reno * add test * fix spell * return all circuits from expression (also duplicates) Co-authored-by: Manoel Marques <manoel@us.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…1121) * VQE construct circuit to return circuits * add reno * add test * fix spell * return all circuits from expression (also duplicates) Co-authored-by: Manoel Marques <manoel@us.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…1121) * VQE construct circuit to return circuits * add reno * add test * fix spell * return all circuits from expression (also duplicates) Co-authored-by: Manoel Marques <manoel@us.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1019: Make VQE return circuits on construct circuit.
Details and comments
Uses the expectation constructed in the previous
construct_circuitand recursively extracts the circuits.