This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Evaluate eigenvalues in MinEigenOptimizer more efficiently #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
manoelmarques,
stefan-woerner and
woodsp-ibm
as code owners
|
Since the application modules today generate legacy operators, i.e. the converters, ising apps etc, until such time all these are changed too, to output opflow natively, I would have thought this use should preserved and not deprecated. We should make the change so everything is consistent and using opflow at the same time and not in bits. As it is the tests are now emitting deprecated warnings and presumably any other code using optimization would too. |
|
I removed the warning in 285b3c0 👍 |
woodsp-ibm
reviewed
Jun 15, 2020
Cryoris
changed the title
stefan-woerner
previously approved these changes
Jun 16, 2020
woodsp-ibm
previously approved these changes
Jun 16, 2020
Cryoris
commented
Jun 16, 2020
woodsp-ibm
approved these changes
Jun 16, 2020
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
…mmunity#1045) * compute eigenvalues more efficiently, if possible * remove note * fix spell * use qubo to compute eigenvalue, not operator * remove deprecation warning * remove eval_operator_at_bitstring * Update qiskit/optimization/algorithms/minimum_eigen_optimizer.py
manoelmarques
pushed a commit
to qiskit-community/qiskit-optimization
that referenced
this pull request
Jan 14, 2021
…mmunity/qiskit-aqua#1045) * compute eigenvalues more efficiently, if possible * remove note * fix spell * use qubo to compute eigenvalue, not operator * remove deprecation warning * remove eval_operator_at_bitstring * Update qiskit/optimization/algorithms/minimum_eigen_optimizer.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
evaluate_at_bitstrfunction used in theMinimumEigenOptimizerused a statevector simulation to compute eigenvalues of an operator. Instead of evaluating the operator we can directly evaluate the underlying QUBO which is much more efficient.