This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 376
Correct coefficient propagation in the operators #1077
Merged
Cryoris
merged 7 commits into
qiskit-community:master
from
Cryoris:apply-all-coeffs-in-eval
Jun 29, 2020
Merged
Correct coefficient propagation in the operators #1077
Cryoris
merged 7 commits into
qiskit-community:master
from
Cryoris:apply-all-coeffs-in-eval
Jun 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
the
Changelog: Bugfix
Include in the Fixed section of the changelog
label
Jun 26, 2020
woodsp-ibm
added
the
stable backport potential
The bug might be minimal and/or import enough to be port to stable
label
Jun 26, 2020
woodsp-ibm
approved these changes
Jun 26, 2020
manoelmarques
pushed a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Jul 28, 2020
* factor in the coeff of ListOp * fix coeff in composedop reduce * state coeff must be squared (applied left and right) * fix norm * add test * add reno
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
* factor in the coeff of ListOp * fix coeff in composedop reduce * state coeff must be squared (applied left and right) * fix norm * add test * add reno
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…skit-aqua#1077) * factor in the coeff of ListOp * fix coeff in composedop reduce * state coeff must be squared (applied left and right) * fix norm * add test * add reno
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 2, 2020
…skit-aqua#1077) * factor in the coeff of ListOp * fix coeff in composedop reduce * state coeff must be squared (applied left and right) * fix norm * add test * add reno
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…skit-aqua#1077) * factor in the coeff of ListOp * fix coeff in composedop reduce * state coeff must be squared (applied left and right) * fix norm * add test * add reno
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Changelog: Bugfix
Include in the Fixed section of the changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The coefficients of some operators (especially
SummedOp
andComposedOp
) are lost on conversion, which is fixed. Also state coefficients in an expectation should be applied squared, since the state is applied from both sides.Details and comments
Some before-and-after comparisons: