This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Fix lint in controlled circuit and Instruction.definition change #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoelmarques
changed the title
Cryoris
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Thanks for the fixes, looks good to me. As context, Qiskit/qiskit#4622 changed Instruction.definition from a list to a QuantumCircuit. To check if a definition is empty one has to access the data of the circuit using .data.
|
@Cryoris In regards of
would it make sense to have an isEmpty() method (or whatever one might care to name it) on Instruction. Although definition and data are public it seems that the usage changed here. |
woodsp-ibm
approved these changes
Jul 6, 2020
woodsp-ibm
added a commit
to woodsp-ibm/qiskit-aqua
that referenced
this pull request
Jul 17, 2020
woodsp-ibm
added a commit
that referenced
this pull request
Jul 17, 2020
manoelmarques
added a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Jul 28, 2020
…kit-community#1100) * Fix lint in controlled circuit * Fixed change to Instruction.definition
manoelmarques
pushed a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Jul 28, 2020
manoelmarques
added a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Jul 28, 2020
…kit-community#1100) * Fix lint in controlled circuit * Fixed change to Instruction.definition
manoelmarques
pushed a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Jul 28, 2020
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
…kit-community#1100) * Fix lint in controlled circuit * Fixed change to Instruction.definition
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…kit-community/qiskit-aqua#1100) * Fix lint in controlled circuit * Fixed change to Instruction.definition
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 2, 2020
…kit-community/qiskit-aqua#1100) * Fix lint in controlled circuit * Fixed change to Instruction.definition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments