This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Be more memory efficient converting SummedOp to MatrixOp #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlapeyre
force-pushed
the
matrix_memory_new
branch
from
c61441c to
92cff4b
Compare
|
If this looks like the right approach, I'll add a release note, etc. to the PR. |
Before, all summands were converted to MatrixOp and then summed. This PR instead converts them one by one and accumulates the result, thereby avoiding building a large intermediate list. Closes qiskit-community#1027 * Add release note
jlapeyre
force-pushed
the
matrix_memory_new
branch
from
92cff4b to
50042da
Compare
woodsp-ibm
approved these changes
Jul 23, 2020
jlapeyre
changed the title
manoelmarques
added a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Jul 28, 2020
…unity#1129) Before, all summands were converted to MatrixOp and then summed. This PR instead converts them one by one and accumulates the result, thereby avoiding building a large intermediate list. Closes qiskit-community#1027 * Add release note Co-authored-by: Manoel Marques <manoel@us.ibm.com>
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
…unity#1129) Before, all summands were converted to MatrixOp and then summed. This PR instead converts them one by one and accumulates the result, thereby avoiding building a large intermediate list. Closes qiskit-community#1027 * Add release note Co-authored-by: Manoel Marques <manoel@us.ibm.com>
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…unity/qiskit-aqua#1129) Before, all summands were converted to MatrixOp and then summed. This PR instead converts them one by one and accumulates the result, thereby avoiding building a large intermediate list. Closes qiskit-community/qiskit-aqua#1027 * Add release note Co-authored-by: Manoel Marques <manoel@us.ibm.com>
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 2, 2020
…unity/qiskit-aqua#1129) Before, all summands were converted to MatrixOp and then summed. This PR instead converts them one by one and accumulates the result, thereby avoiding building a large intermediate list. Closes qiskit-community/qiskit-aqua#1027 * Add release note Co-authored-by: Manoel Marques <manoel@us.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before all summands were converted to MatrixOp and then summed. This
PR instead converts them one by one and accumulates the result.
Previously the method
ListOp.to_matrix_opwas called when converting an instance ofSummedOpto aMatrixOp. This PR adds the more specific methodSummedOp.to_matrix_op, which avoid allocating a large array of matrices as an intermediate step.Closes #1027