This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Improve inequality for "a" in Shor's Algorithm documentation #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like an improvement to me. |
|
Maybe given that |
|
@woodsp-ibm I like that a lot! The inequality looks a lot nicer now in my opinion. |
|
FYI: The build overall currently has a problem due to very recent change to Terra, that we need to address, hence you see all the PRs here failing presently, including yours. |
woodsp-ibm
approved these changes
Jul 23, 2020
|
@woodsp-ibm Yeah, I had a feeling that was the case :) Thanks for putting my mind at ease that our inequality didn't break Qiskit Aqua! 😂 |
woodsp-ibm
changed the title
manoelmarques
pushed a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Jul 28, 2020
…community#1133) * Improve inequality for "a" in Shor's Algorithm * change inequality to 1 < a < N
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
…community#1133) * Improve inequality for "a" in Shor's Algorithm * change inequality to 1 < a < N
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…community/qiskit-aqua#1133) * Improve inequality for "a" in Shor's Algorithm * change inequality to 1 < a < N
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…community/qiskit-aqua#1133) * Improve inequality for "a" in Shor's Algorithm * change inequality to 1 < a < N
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The argument "a" can be written more succinctly. I reworded the description to use the inequality rather than stating a separate minimum value.
Details and comments
I believe incorporating all restrictions in one inequality is easier to understand. In addition, it sounds better to say "any integer" rather than "a random integer" because there may exist methods of choosing a more effective "a" for period finding.
a: Any integer that satisfies 2 ≤ a < N and gcd(a, N) = 1.