This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Add validation of sizes of arguments of OptimizationResults and unit tests #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-imamichi
requested review from
manoelmarques,
stefan-woerner and
woodsp-ibm
as code owners
|
@manoelmarques @woodsp-ibm If possible, could you include it in the new release? It is a bug fix of the converter rework #1061 and #1131. |
woodsp-ibm
approved these changes
Aug 5, 2020
|
Thank you for merging this bug fix at the last moment to release the new version. |
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
…tests (qiskit-community#1167) * add more unit tests of converters * fix min_eigen_optimizer
manoelmarques
pushed a commit
to qiskit-community/qiskit-optimization
that referenced
this pull request
Jan 14, 2021
…tests (qiskit-community/qiskit-aqua#1167) * add more unit tests of converters * fix min_eigen_optimizer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OptimizationResultnewly introducedvariablesclass variables in #1122.But, there is not enough check of arguments. So I added a check of sizes of
OptimizationResult._xandOptimizationResult._variables.I fix bugs of generation of
OptimizationResultdetected by this check.#1131 modifies the way to interpret
OptimizationResultso thatOptimizationResultbecomes read-only.But, some
interpretdid not treatvariablescorrectly. I notice that there is no unit test aboutOptimizationResult.variable_namesandOptimizationResult.variables_dict.So I added some relevant unit tests.
Details and comments