Correct the UCCSD.compute_excitation_lists()

[tsura-crisaldo]

Summary

Correct the UCCSD.compute_excitation_lists(), when indicate args: active_occupied, active_unoccupied, it now gives the correct excitation lists.

Details and comments

Details of the issue and the result after fixed the issue:
https://qiskit.slack.com/archives/CB6C24TPB/p1597341799066200?thread_ts=1597133029.202500&cid=CB6C24TPB
https://qiskit.slack.com/archives/CB6C24TPB/p1597341799066400?thread_ts=1597133029.202500&cid=CB6C24TPB

This is the file to test and compare the old and new version of UCCSD.compute_excitation_lists():
Test the Corrected UCCSD.compute_excitation_lists().zip

[CLAassistant]

All committers have signed the CLA.

[woodsp-ibm]

Thanks for supplying the fix. Can you please sign the CLA - the email/id you used on the commit should match your github email - maybe that you did not set it up in git locally and its defaulting to some locally generated email that does not match.
When I had mentioned tests in Slack we have these as unit tests in the test folder here. These are then run to assure the code works as expected. Anyway I created one locally, in order to test what you did as well as other behavior of the excitation list computation, to ensure it works as expected since its clear the bug you found was not covered by unit testing. I'll add it to your fork once the CLA is sorted so it can all come as a single contribution. Sound ok?

[tsura-crisaldo]

Sounds good!
But there is a problem when signing the CLA.
Follow your reply, I used git config -l --local and git config -l --local --show-origin to check the user.email in my qiskit-aqua repository, both of them show the same email as the email I currently use in my account (the @users.noreply.github.com one).
I also followed the way https://docs.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user to check the message in the blue question mark, but there is no blue question mark:

I also clicked the let us recheck many times.
It still shows the same message CLA not signed yet.

[woodsp-ibm]

Just to double check here is some info from github around account emails https://docs.github.com/en/enterprise/2.13/user/articles/setting-your-commit-email-address-in-git

If I look at the commit log locally, in my clone of your fork, the email of the entry looks like ....macbook-pro.gateway (I did not post the full thing here but hopefully its enough that you can see what is going on.

[tsura-crisaldo]

Thank you so much for your help!
I've signed the CLA now.

[woodsp-ibm]

Thanks once again for finding and fixing the bug and making the contribution here, as well as persevering with the CLA to get it signed.

[jlapeyre]

There is a typo here: ixes rather than fixes

[woodsp-ibm]

Thanks, I'll take care of it