This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Deprecate the CircuitFactory and derived types
#1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
the
Changelog: Deprecation
Cryoris
requested review from
levbishop,
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
woodsp-ibm
reviewed
Oct 14, 2020
qiskit/aqua/components/uncertainty_models/gaussian_conditional_independence_model.py
Outdated
Show resolved
Hide resolved
woodsp-ibm
reviewed
Oct 14, 2020
…_independence_model.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
…it-aqua into deprecate-circuit-factories
woodsp-ibm
approved these changes
Oct 15, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…qiskit-aqua#1348) * deprecate the circuit factories * start to suppress deprecation warnings * start to suppress deprecation warnings * fix warnings from finance AE * add reno * capture deprecation warnings * Update qiskit/aqua/components/uncertainty_models/gaussian_conditional_independence_model.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * fix typos Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
manoelmarques
pushed a commit
to qiskit-community/qiskit-finance
that referenced
this pull request
Jan 19, 2021
…qiskit-aqua#1348) * deprecate the circuit factories * start to suppress deprecation warnings * start to suppress deprecation warnings * fix warnings from finance AE * add reno * capture deprecation warnings * Update qiskit/aqua/components/uncertainty_models/gaussian_conditional_independence_model.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * fix typos Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blocked by #1342.
Closes #944 and #1326.
Details and comments
Deprecate the
CircuitFactoryand derived types. TheCircuitFactoryhasbeen introduced as temporary class when the
QuantumCircuitmissed somefeatures necessary for applications in Aqua. Now that the circuit has all required
functionality, the circuit factory can be removed.
The replacements are shown in the following table.