Fix opflow bugs #1390

ikkoham · 2020-10-26T15:42:05Z

Summary

DictStateFn.sample() could only handle real amplitudes, but it is fixed to handle complex amplitudes. (The sample() method in DictStateFn does not handle complex amplitudes #1311)
Trotter class did not use the reps argument in constructor. (Trotter class does not use the reps argument in initialization #1317)
Raise an AquaError if CircuitSampler samples an empty operator. (CircuitSampler fails on expressions consisting only of OperatorStateFns #1321)
Fix to_opflow() when coefficients are complex (Incorrectly generated matrix out of a list of Pauli strings after converting to opflow #1381)

TODO:

remove optional in StateFn

qiskit/aqua/operators/converters/circuit_sampler.py

qiskit/aqua/operators/legacy/weighted_pauli_operator.py

qiskit/aqua/operators/state_fns/dict_state_fn.py

qiskit/aqua/operators/state_fns/operator_state_fn.py

Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com>

…cqua into fix-opflow-bugs

This reverts commit c884ebb.

qiskit/aqua/operators/legacy/weighted_pauli_operator.py

* fix qiskit-community#1311 * fix qiskit-community#1317 * add a test of reps for trotterization * fix tests for qiskit-community#1311 * fix typing * fix qiskit-community#1321 * add release note * fix qiskit-community#1381 * add a test for to_opflow * Update qiskit/aqua/operators/converters/circuit_sampler.py Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> * remove None from constructor * simplify logic * Revert "remove None from constructor" This reverts commit c884ebb. * add releasenote * simplify logic (not iscomplex to isreal) * remove Optional * Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py * Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py * Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> Co-authored-by: Panagiotis Barkoutsos <bpa@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>

* fix qiskit-community/qiskit-aqua#1311 * fix qiskit-community/qiskit-aqua#1317 * add a test of reps for trotterization * fix tests for qiskit-community/qiskit-aqua#1311 * fix typing * fix qiskit-community/qiskit-aqua#1321 * add release note * fix qiskit-community/qiskit-aqua#1381 * add a test for to_opflow * Update qiskit/aqua/operators/converters/circuit_sampler.py Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> * remove None from constructor * simplify logic * Revert "remove None from constructor" This reverts commit c884ebba123adee22f252e11f90964a6defaec38. * add releasenote * simplify logic (not iscomplex to isreal) * remove Optional * Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py * Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py * Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> Co-authored-by: Panagiotis Barkoutsos <bpa@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>

ikkoham added 9 commits October 23, 2020 13:25

fix qiskit-community#1311

902513e

fix qiskit-community#1317

2b2c9dd

add a test of reps for trotterization

0060fd2

fix tests for qiskit-community#1311

8a592fd

fix typing

f87a39a

fix qiskit-community#1321

5acedfb

add release note

ce2ce74

fix qiskit-community#1381

42c661b

add a test for to_opflow

f848fce

ikkoham requested review from levbishop, manoelmarques, pbark, stefan-woerner and woodsp-ibm as code owners October 26, 2020 15:42

woodsp-ibm requested a review from jlapeyre October 26, 2020 18:26

jlapeyre reviewed Oct 26, 2020

View reviewed changes

qiskit/aqua/operators/converters/circuit_sampler.py Outdated Show resolved Hide resolved

woodsp-ibm reviewed Oct 26, 2020

View reviewed changes

ikkoham and others added 2 commits October 27, 2020 09:04

Update qiskit/aqua/operators/converters/circuit_sampler.py

ff84ed4

Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com>

remove None from constructor

c884ebb

ikkoham marked this pull request as draft October 27, 2020 01:56

Panagiotis Barkoutsos and others added 5 commits October 27, 2020 10:27

Merge branch 'master' into fix-opflow-bugs

f2f6fa8

simplify logic

91f782a

Merge branch 'fix-opflow-bugs' of https://github.com/ikkoham/qiskit-a…

feee254

…cqua into fix-opflow-bugs

Merge branch 'master' into fix-opflow-bugs

effbf30

Merge branch 'master' into fix-opflow-bugs

c4d3113

ikkoham force-pushed the fix-opflow-bugs branch from 6b4cfcd to c4d3113 Compare October 28, 2020 02:45

ikkoham added 2 commits October 28, 2020 12:50

Revert "remove None from constructor"

dac3b1a

This reverts commit c884ebb.

add releasenote

b8f01bc

ikkoham marked this pull request as ready for review October 28, 2020 04:37

simplify logic (not iscomplex to isreal)

cca3498

remove Optional

19b04e4

woodsp-ibm reviewed Oct 30, 2020

View reviewed changes

qiskit/aqua/operators/legacy/weighted_pauli_operator.py Outdated Show resolved Hide resolved

Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py

249e64b

woodsp-ibm reviewed Oct 30, 2020

View reviewed changes

qiskit/aqua/operators/legacy/weighted_pauli_operator.py Outdated Show resolved Hide resolved

Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py

6bd7969

woodsp-ibm reviewed Oct 30, 2020

View reviewed changes

qiskit/aqua/operators/legacy/weighted_pauli_operator.py Outdated Show resolved Hide resolved

woodsp-ibm added 2 commits October 30, 2020 14:59

Update qiskit/aqua/operators/legacy/weighted_pauli_operator.py

020f527

Merge branch 'master' into fix-opflow-bugs

c84e868

woodsp-ibm approved these changes Oct 30, 2020

View reviewed changes

manoelmarques merged commit 4ff340d into qiskit-community:master Oct 31, 2020

manoelmarques added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 9, 2020

manoelmarques added the Changelog: Bugfix Include in the Fixed section of the changelog label Nov 10, 2020

ikkoham deleted the fix-opflow-bugs branch November 10, 2020 04:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix opflow bugs #1390

Fix opflow bugs #1390

ikkoham commented Oct 26, 2020 •

edited

Loading

Fix opflow bugs #1390

Fix opflow bugs #1390

Conversation

ikkoham commented Oct 26, 2020 • edited Loading

Summary

ikkoham commented Oct 26, 2020 •

edited

Loading