This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Fix to MultivariateDistribution class, Add Data Discretization & Truncation function #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in Multivariate Distribution induced an error
We have had the jsonschema version capped since it was capped in terra. However there was no clear reason for this in terra and it limits interoperability with other python packages. Especially because jsonschema is commonly used library across the python ecosystem. The version we were capping to was also quite old being release 2.5 years ago. This commit removes the cap so that people can run aqua in environments where newer jsonschema is required.
…ma-stable [Stable] Remove jsonschema cap
Zoufalc
changed the title
Zoufalc
changed the title
woodsp-ibm
approved these changes
Dec 6, 2019
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…er_ouf Fix to MultivariateDistribution class, Add Data Discretization & Truncation function
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…er_ouf Fix to MultivariateDistribution class, Add Data Discretization & Truncation function
manoelmarques
pushed a commit
to qiskit-community/qiskit-machine-learning
that referenced
this pull request
Feb 27, 2021
…er_ouf Fix to MultivariateDistribution class, Add Data Discretization & Truncation function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Aqua issue #732
& move data preparation from qgan.py to utils/dataset_helper.py
Details and comments
Fix constructor of the MultivariateDistribution class, i.e. reorder arguments in init
def init(self, num_qubits, probabilities=None, low=[], high=[]):
Add data discretization & truncation functionality -- enables digital representation of classical data in qubit registers -- to dataset_helper.py