This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Fix grover optimizer #966
Merged
Fix grover optimizer #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch from origin
grover optimizer didn't handle maximization correctly.
Cryoris
approved these changes
May 11, 2020
woodsp-ibm
approved these changes
May 11, 2020
manoelmarques
pushed a commit
to qiskit-community/qiskit-optimization
that referenced
this pull request
Jan 14, 2021
* fix grover optimizer grover optimizer didn't handle maximization correctly. * Update test_grover_optimizer.py * use aqua_globals as RNG * fix seed for tests Co-authored-by: Cryoris <jules.gacon@googlemail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grover optimizer was not handling maximization problems correctly.
Updated the optimizer and added unit test.