This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Sort parameters in variational distributions #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
dongreenberg,
manoelmarques and
woodsp-ibm
as code owners
woodsp-ibm
approved these changes
May 14, 2020
manoelmarques
pushed a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #967, sort the parameters by name in the variational uncertainty distributions to ensure reproducible results.
Details and comments
Since the input varform can be a
QuantumCircuit, the list of parameters is not sorted in the same order every time. Since the parameters are optimized via an optimizer that returns an update step as array, the way that these parameters are bound to the paramterized circuit is not constant. This can lead to reproducibility issues.