Replacing AWSBraketJob with AmazonBraketTask #105

robotastray · 2023-06-08T21:53:45Z

Summary

This pull request aims to fix issue 45

Details and comments

I have replaced AWSBraketJob with AmazonBraketTask in the code.
And I have re-ran the notebooks docs/tutorials/0_tutorial_qiskit-braket-provider_overview.ipynb and docs/how_tos/2_how_to_retrieve_results_from_backend.ipynb to reflect these changes.

Note that I have installed the modified package locally on my machine to do the last step. Once this pull request is merged and qiskit-braket-provider is deployed, these changes will be visible to anybody installing the package via pip install qiskit-braket-provider.

robotastray · 2023-06-08T22:04:55Z

@JordanAWS would you kindly have a look and see if my solution is suitable for you?
Thank you.
robotAstray

robotastray · 2023-06-12T20:38:36Z

I will fix the mistakes and re-commit @JordanAWS

kshitijc

Thanks for the PR @robotastray! Please make updates to fix the failing checks.

docs/tutorials/0_tutorial_qiskit-braket-provider_overview.ipynb

qiskit_braket_provider/__init__.py

qiskit_braket_provider/providers/__init__.py

qiskit_braket_provider/providers/braket_job.py

robotastray

re-formatting completed with black python

robotastray

please note that I mistakenly re-names braket_job to braket_task indocs/tutorials/0_tutorial_qiskit-braket-provider_overview.ipynb so I fixed it in this commit by reverting to what we had previously.

robotastray · 2023-06-12T21:43:16Z

@kshitijc I think it should be ready. Thank you

kshitijc

Thanks for the updates @robotastray! Could you please look at the failing checks and make updates to fix those as well?

qiskit_braket_provider/providers/braket_job.py

robotastray · 2023-06-13T07:40:37Z

thank you for your message I will fix this now, and test

…n the JobV1 class

…tJob'

robotastray · 2023-06-13T18:03:09Z

I will check the formatting. And commit the changes

kshitijc

Could you also please confirm whether you are able to successfully execute all notebooks in the tutorials and how-to folders?

tests/providers/test_braket_job.py

…t.aws import AwsQuantumTask' (wrong-import-order)

robotastray · 2023-06-13T18:22:28Z

Could you also please confirm whether you are able to successfully execute all notebooks in the tutorials and how-to folders?

I ran the notebooks prior I made all the latest changes by installing locally the package for qiskit-braket-provider mirroring the repository containing the modifications I have made. I will re-run all the notebooks again and confirm once done

robotastray · 2023-06-13T18:43:25Z

I will run the notebook and push the commits again when done.

kshitijc · 2023-06-13T20:14:37Z

Great! Could you please fix the failing style check as well?

robotastray · 2023-06-13T22:00:39Z

just a note, I am not able to run the 4_how_to_verbatim_circuits.ipynb notebook and I can see there were problems related to it prior I forked the repo so I will skip `4_how_to_verbatim_circuits.ipynb.

YOu can see in the following link that there were errors before https://github.com/qiskit-community/qiskit-braket-provider/blob/2434a9a29900972e5fe6dace3804384ee08d9df7/docs/how_tos/4_how_to_verbatim_circuits.ipynb

robotastray · 2023-06-13T22:47:49Z

I have run tox -elint on the root folder and these were the results

lint: commands[3]> mypy --install-types --non-interactive .
qiskit_braket_provider/providers/braket_backend.py:252: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
qiskit_braket_provider/providers/braket_backend.py:255: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/providers/test_braket_backend.py:229: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/providers/test_braket_backend.py:230: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
Success: no issues found in 19 source files
  lint: OK (15.66=setup[0.14]+cmd[0.76,8.77,5.13,0.85] seconds)
  congratulations :) (16.02 seconds)

I think now all checks should pass successfully (I hope) 🤞
update: 14th June 2023 (time: 00:24 - London):
This might be an issue:

mypy qiskit_braket_provider/providers/braket_backend.py --check-untyped-defs  

qiskit_braket_provider/providers/braket_backend.py:250: error: Incompatible types in assignment (expression has type "Iterable[Any]", variable has type "List[Any]")  [assignment]

kshitijc · 2023-06-14T00:44:53Z

Nice work @robotastray! 👍

* replacing AWSBraketJob with AmazonBraketTask * run the notebooks containing AmazonBraketTask * deprecation warning added for AWSBraketJob class * formatting fixed * re-add <JOB_ARN> * fix breaking changes on /provider/__init__.py and __init__.py * rename job_id to task_id argument for AmazonBraketTask() * rename braket_jobs_states to braket_tasks_states * add task_id method to access the task_id similar to the one we have in the JobV1 class * adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob' * formatting test_braket_job.py * correcting definition of AWSBraketJob * rewriting line 184 in braket_job.py * adding class docstring to AWSBraketJob * standard import 'from warnings import warn' placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order) * docstring fix in test_braket_job.py * assert the job id in test_AWS_job() function in test_braket_job.py * running how to notebook #0 * running how to notebook #1 * running how to notebook #2 * running how to notebook #3 * running how to notebook number 5 * running tutorial notebook number 3 * tutorial number 0

Replacing AWSBraketJob with AmazonBraketTask (qiskit-community#105)

* replacing AWSBraketJob with AmazonBraketTask * run the notebooks containing AmazonBraketTask * deprecation warning added for AWSBraketJob class * formatting fixed * re-add <JOB_ARN> * fix breaking changes on /provider/__init__.py and __init__.py * rename job_id to task_id argument for AmazonBraketTask() * rename braket_jobs_states to braket_tasks_states * add task_id method to access the task_id similar to the one we have in the JobV1 class * adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob' * formatting test_braket_job.py * correcting definition of AWSBraketJob * rewriting line 184 in braket_job.py * adding class docstring to AWSBraketJob * standard import 'from warnings import warn' placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order) * docstring fix in test_braket_job.py * assert the job id in test_AWS_job() function in test_braket_job.py * running how to notebook #0 * running how to notebook #1 * running how to notebook #2 * running how to notebook #3 * running how to notebook number 5 * running tutorial notebook number 3 * tutorial number 0

robotastray added 2 commits June 8, 2023 22:04

replacing AWSBraketJob with AmazonBraketTask

1925c68

run the notebooks containing AmazonBraketTask

0344ac0

deprecation warning added for AWSBraketJob class

64c2456

formatting fixed

1e10283

kshitijc reviewed Jun 12, 2023

View reviewed changes

robotastray commented Jun 12, 2023

View reviewed changes

robotastray added 3 commits June 12, 2023 22:01

re-add <JOB_ARN>

9ba872a

fix breaking changes on /provider/__init__.py and __init__.py

abb7925

rename job_id to task_id argument for AmazonBraketTask()

c0450cc

robotastray commented Jun 12, 2023

View reviewed changes

kshitijc reviewed Jun 13, 2023

View reviewed changes

robotastray added 6 commits June 13, 2023 08:53

rename braket_jobs_states to braket_tasks_states

ec061fd

add task_id method to access the task_id similar to the one we have i…

d4e6f0c

…n the JobV1 class

adding tests for new class 'AmazonBraketTask' and old class 'AWSBrake…

edaba8d

…tJob'

formatting test_braket_job.py

abbd886

correcting definition of AWSBraketJob

2b47a25

rewriting line 184 in braket_job.py

5e05e45

kshitijc reviewed Jun 13, 2023

View reviewed changes

tests/providers/test_braket_job.py Show resolved Hide resolved

robotastray added 2 commits June 13, 2023 19:15

adding class docstring to AWSBraketJob

7352c30

standard import 'from warnings import warn' placed before 'from brake…

de911b9

…t.aws import AwsQuantumTask' (wrong-import-order)

robotastray added 2 commits June 13, 2023 19:39

docstring fix in test_braket_job.py

f54b6f1

assert the job id in test_AWS_job() function in test_braket_job.py

ee16a98

robotastray added 4 commits June 13, 2023 22:43

running how to notebook #0

b75edb8

running how to notebook #1

cc748ff

running how to notebook #2

c67bf16

running how to notebook #3

b8aa5c6

running how to notebook number 5

35f723f

robotastray force-pushed the main branch from 6a29885 to 35f723f Compare June 13, 2023 22:06

robotastray added 2 commits June 13, 2023 23:33

running tutorial notebook number 3

fc0617a

tutorial number 0

8f4eee9

kshitijc merged commit ccd0db7 into qiskit-community:main Jun 14, 2023

robotastray added a commit to robotastray/qiskit-braket-provider that referenced this pull request Jun 14, 2023

Merge pull request #2 from qiskit-community/main

293206b

Replacing AWSBraketJob with AmazonBraketTask (qiskit-community#105)

jcjaskula-aws mentioned this pull request Jan 20, 2024

Rename AWSBraketJob to AmazonBraketTask #93

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replacing AWSBraketJob with AmazonBraketTask #105

Replacing AWSBraketJob with AmazonBraketTask #105

robotastray commented Jun 8, 2023

robotastray commented Jun 8, 2023

robotastray commented Jun 12, 2023

kshitijc left a comment

robotastray left a comment •

edited

Loading

robotastray left a comment •

edited

Loading

robotastray commented Jun 12, 2023

kshitijc left a comment

robotastray commented Jun 13, 2023

robotastray commented Jun 13, 2023

kshitijc left a comment

robotastray commented Jun 13, 2023 •

edited

Loading

robotastray commented Jun 13, 2023

kshitijc commented Jun 13, 2023

robotastray commented Jun 13, 2023

robotastray commented Jun 13, 2023 •

edited

Loading

kshitijc commented Jun 14, 2023

Replacing AWSBraketJob with AmazonBraketTask #105

Replacing AWSBraketJob with AmazonBraketTask #105

Conversation

robotastray commented Jun 8, 2023

Summary

Details and comments

robotastray commented Jun 8, 2023

robotastray commented Jun 12, 2023

kshitijc left a comment

Choose a reason for hiding this comment

robotastray left a comment • edited Loading

Choose a reason for hiding this comment

robotastray left a comment • edited Loading

Choose a reason for hiding this comment

robotastray commented Jun 12, 2023

kshitijc left a comment

Choose a reason for hiding this comment

robotastray commented Jun 13, 2023

robotastray commented Jun 13, 2023

kshitijc left a comment

Choose a reason for hiding this comment

robotastray commented Jun 13, 2023 • edited Loading

robotastray commented Jun 13, 2023

kshitijc commented Jun 13, 2023

robotastray commented Jun 13, 2023

robotastray commented Jun 13, 2023 • edited Loading

kshitijc commented Jun 14, 2023

robotastray left a comment •

edited

Loading

robotastray left a comment •

edited

Loading

robotastray commented Jun 13, 2023 •

edited

Loading

robotastray commented Jun 13, 2023 •

edited

Loading