-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test docs CI #124
Test docs CI #124
Conversation
Hi @arnaucasau - thanks for opening this PR! Just have a few quick questions I have when you get a chance
|
Hi @guomanmin, thanks for reviewing the PR! In this pull request, I added a new job into the lint.yml to test the building of the documentation, and the reason we configure pandoc in that job is because it's a requirement for Sphinx. This will be useful in other PRs like this one where we are updating the ecosystem sphinx theme. As for the version of pandoc it's not a problem in this case :) |
Hi @arnaucasau, as per the official sphinx documentation, pandoc doesn't seem to be a requirement for sphinx and sphinx-theme. Pandoc seems to be more suitable for document conversion. Can you try checking this without adding this dependency to see if that builds the documentation or this requirement is necessary for anything else? |
Of course @virajvchaudhari! I tried without adding the dependency and as you can see in the commit the test failed with the error:
I have added again the package in the last commit. |
I see what's happening there. Thanks for the clarification @arnaucasau! |
Thanks for the approval @virajvchaudhari! Can you merge this PR please? I don't have write access :) |
Summary
Added a test to build the documentation and upload it as part of CI as an artifact for PRs.