Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alltrue from the tests #75

Closed
fretchen opened this issue Aug 20, 2023 · 1 comment
Closed

Remove alltrue from the tests #75

fretchen opened this issue Aug 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@fretchen
Copy link
Collaborator

Informations

  • Qiskit Cold atoms version:
  • Python version:
  • Operating system:

What is the current behavior?

Currently we run tests with alltrue from numpy. However, this is depreceated as of 1.25 and should be removed.

Steps to reproduce the problem

Run the github actions with numpy >= 1.25

What is the expected behavior?

The tests must not fail anymore

Suggested solutions

The suggested solution is to use all instead of alltrue.
@fretchen fretchen added the bug Something isn't working label Aug 20, 2023
@robotAstray robotAstray mentioned this issue Aug 30, 2023
Merged
@fretchen
Copy link
Collaborator Author

fretchen commented Sep 2, 2023

fixed with #76

@fretchen fretchen closed this as completed Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fretchen