Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace numpy.alltrue with numpy.all #76

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

robotAstray
Copy link
Contributor

Summary

This pull request addresses issue #75 related to the deprecation of alltrue in favor of all in numpy versions 1.25 and later. The tests in Qiskit Cold Atoms were failing when run with versions >= 1.25.

Changes:

Replaced usages of numpy.alltrue with numpy.all throughout the codebase, to be specific in:

  • test/test_fermion_circuit_solver.py
  • test/test_spin_circuit_solver.py

@robotAstray robotAstray marked this pull request as ready for review August 30, 2023 09:11
Copy link
Collaborator

@fretchen fretchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This looks mostly good to me. Two minor comments:

  • Could you also update the requirements such that numpy is not pinned anymore ? Normally, this should be enabled by this PR.
  • Could you add a reno file that describes the changes of this PR ?

@robotAstray
Copy link
Contributor Author

@fretchen, I have added the release notes and removed the specific version requirement for Numpy by substituting numpy >= 1.17 with just numpy. (I removed the lower bound requirement so that the project works with any version of Numpy, including versions released after the current requirements was set.)

Copy link
Collaborator

@fretchen fretchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes in the requirements.txt which came from a mix-up with the merge status of #74

requirements.txt Outdated Show resolved Hide resolved
@robotAstray
Copy link
Contributor Author

Revert the changes in the requirements.txt which came from a mix-up with the merge status of #74

that's done. Thank you.

@robotAstray robotAstray requested a review from fretchen August 30, 2023 18:45
Copy link
Collaborator

@fretchen fretchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@fretchen fretchen merged commit 8578989 into qiskit-community:main Aug 30, 2023
fretchen added a commit that referenced this pull request Sep 2, 2023
This is now possible thanks to #76
@robotAstray robotAstray deleted the issue-75-bug-fix branch September 19, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants