-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace numpy.alltrue
with numpy.all
#76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. This looks mostly good to me. Two minor comments:
- Could you also update the requirements such that numpy is not pinned anymore ? Normally, this should be enabled by this PR.
- Could you add a reno file that describes the changes of this PR ?
@fretchen, I have added the release notes and removed the specific version requirement for Numpy by substituting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes in the requirements.txt which came from a mix-up with the merge status of #74
that's done. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR.
This is now possible thanks to #76
Summary
This pull request addresses issue #75 related to the deprecation of
alltrue
in favor ofall
in numpy versions 1.25 and later. The tests in Qiskit Cold Atoms were failing when run with versions >= 1.25.Changes:
Replaced usages of
numpy.alltrue
withnumpy.all
throughout the codebase, to be specific in:test/test_fermion_circuit_solver.py
test/test_spin_circuit_solver.py