Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibrations Definition #26
Calibrations Definition #26
Changes from 184 commits
768599e
75214af
40bf8bd
2639b0d
bd0529a
c992ccc
9092094
8c4c21e
fbc2dc7
47ab364
a9bc280
f952975
ec956ae
ae24a11
f96ab98
7dd1bed
edc402d
ffe4d87
14cc378
d70acce
b919f67
aa9b1ca
b58d3cd
b08c481
a73d9e3
1d4923f
f74534e
72ce1c0
2e22059
8053c5c
75a5cfb
0862722
d35b0ed
dfc2788
70f4616
50af0e3
800d1d0
2af8cb0
e75df84
4461153
f2d680e
6019b78
0a01a7a
509aa44
9085018
d014b17
490ad63
fa27ef5
b314294
0f60d1f
9de4086
7bac467
619fea3
373cb38
38deb52
602f001
18ff956
fe07b6e
09f1cc3
9344834
d8dff58
8f8a569
174c4ec
1546e48
f4bf40d
f9e42ed
05d61eb
9194031
afaba9b
5265030
f817f5c
290e2ef
e56953f
2646227
3dfcb3d
91aa4cd
6833d1f
0c1ede5
5426c68
54db71c
c8f4fb5
37a2eaf
113150a
3006695
5d40e8c
91c239d
c4b7260
6ebdc48
b4a0f74
d06bb4f
7c40368
1b6bf14
e9d38ab
9e4ea3b
0ab664a
1803285
f7ee6b9
32892d5
3d2a052
8148d0e
13ed686
83f82a7
b83adf3
1c6d1e3
62d1728
d19dfe8
fa5edc1
5033b48
f067c7d
23402a7
4160914
84b49c9
4e9f266
d99c429
a743a9a
b6d9dec
bc11c38
62b42b6
f8132bb
0d267c2
f6f4b8a
f94b34e
a7f8a36
980f2c2
98530d4
d85f5f6
3900b82
0c519b5
987bc81
129db5b
47c0a44
80bc820
f7747c6
aaf1479
0a49a3c
320b377
f9c0490
3c56906
07d5ee1
2009af4
e9b44e7
75fadc7
54c3e81
db33772
4f04ae4
61a0ba1
fd09136
1b14366
27af03c
ced5333
7031ec1
6ada9ce
bb4fb81
bab9b9a
ba2bc1b
3166ae2
1dd07e8
da84b8a
7209231
8681523
860196a
6033672
3e844bc
dee2f58
0f3907c
dae34e1
145c190
90b0dd8
c597e52
a15b6a9
fd7db9d
abbe216
03f2d7b
4fe70a1
dd773a1
7c43741
83aeb1b
05b9582
e0c6b7f
31a11e7
c666777
33f4811
c492b35
048684d
7316a9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline, this induces tight coupling to execution chain because this class exists for generating a backend dependent runtime option though the
Calibrations
is just a database of programs and parameters. If you really think this coupling is necessary,Calibrations
should be an abstract class. There is no calibration operation without backend. We should define calibration subclass for every target backend configuration.I think the right direction should be exporting configured backend with
Calibration
, and override runtime option with parameters in the backend. This runtime option generation should be done byExperiment
class.