-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interleaved RB #28
Interleaved RB #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Could you please move the notebook to:
qiskit-experiments.docs.tutorials
?
This will be the place for the future tutorials. -
The error bars in the notebook are printed as '0.0000' since they are quite small.
Maybe it will be better to use an exponential presentation of the error & error bars:
e.g. EPC = 1.9 x 10^(-3) +/- 1.0 x 10^(-5) -
In order to verify the results could you also print in the notebook the backend reported depolarized errors of the
x
andcx
gates?
EPC of 2-qubit standard RB should be ~1.5 of thecx
error
EPC of 2-qubit interleaved RB (with gatecx
) should be ~0.75 xcx
error
EPC of 1-qubit interleaved RB (with gatex
) should be ~0.5 xx
error
multi_curve_fit_data | ||
ydata: array of ydata returned from curve_fit_data or | ||
multi_curve_fit_data | ||
series: 1D int array that specifies the data series |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I once wrote a comment in #19 about this line. I find it difficult to understand what "1D int array that specifies the data series" means.
qiskit_experiments/randomized_benchmarking/interleaved_rb_analysis.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/randomized_benchmarking/interleaved_rb_analysis.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review of data processing
qiskit_experiments/randomized_benchmarking/interleaved_rb_analysis.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/randomized_benchmarking/interleaved_rb_analysis.py
Outdated
Show resolved
Hide resolved
* Beginning of interleaved RB and several fixes to related classes * Small refactor to mean_xy_data * Updated mean_xy_data to support multi series * Using multi_curve_fit in interleaved analysis (not working correctly yet) * multi_curve_fit seems to work now * Anaylsis results for interleaved rb * Linting * Linting * Linting * Added interleaved RB to the notebook * Small fixes * Moved RB notebook to tutorial folder * Linting * Switch to Chris' version of multi_mean_xy_data * Small fixes * Added equations * Linting * Running black * Bugfixes * Added interleaved analysis to __init__ Co-authored-by: Helena Zhang <helena@astbb.com>
Summary
Details and comments