Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interleaved RB #28

Merged
merged 23 commits into from
May 12, 2021
Merged

Conversation

gadial
Copy link
Contributor

@gadial gadial commented Apr 26, 2021

Summary

Details and comments

@gadial gadial changed the title [WIP] Interleaved RB Interleaved RB Apr 28, 2021
@ShellyGarion ShellyGarion self-requested a review April 29, 2021 06:36
Copy link
Contributor

@ShellyGarion ShellyGarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you please move the notebook to: qiskit-experiments.docs.tutorials ?
    This will be the place for the future tutorials.

  2. The error bars in the notebook are printed as '0.0000' since they are quite small.
    Maybe it will be better to use an exponential presentation of the error & error bars:
    e.g. EPC = 1.9 x 10^(-3) +/- 1.0 x 10^(-5)

  3. In order to verify the results could you also print in the notebook the backend reported depolarized errors of the x and cx gates?
    EPC of 2-qubit standard RB should be ~1.5 of the cx error
    EPC of 2-qubit interleaved RB (with gate cx) should be ~0.75 x cx error
    EPC of 1-qubit interleaved RB (with gate x) should be ~0.5 x x error

multi_curve_fit_data
ydata: array of ydata returned from curve_fit_data or
multi_curve_fit_data
series: 1D int array that specifies the data series
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I once wrote a comment in #19 about this line. I find it difficult to understand what "1D int array that specifies the data series" means.

Copy link
Collaborator

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review of data processing

@gadial gadial requested a review from chriseclectic May 10, 2021 06:19
@coruscating coruscating self-requested a review May 12, 2021 20:04
@coruscating coruscating merged commit b85f1cc into qiskit-community:main May 12, 2021
@coruscating coruscating added this to the Release 0.1 milestone Jun 16, 2021
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
* Beginning of interleaved RB and several fixes to related classes

* Small refactor to mean_xy_data

* Updated mean_xy_data to support multi series

* Using multi_curve_fit in interleaved analysis (not working correctly yet)

* multi_curve_fit seems to work now

* Anaylsis results for interleaved rb

* Linting

* Linting

* Linting

* Added interleaved RB to the notebook

* Small fixes

* Moved RB notebook to tutorial folder

* Linting

* Switch to Chris' version of multi_mean_xy_data

* Small fixes

* Added equations

* Linting

* Running black

* Bugfixes

* Added interleaved analysis to __init__

Co-authored-by: Helena Zhang <helena@astbb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants