Initial commit of tools for qec #211
Conversation
|
|
|
I think you pushed some extraneous files |
dcmckayibm
changed the title
|
Can you put an example notebook in |
|
Thanks. I'll add the notebook, remove the mystery files and do some other sorting out on Monday. |
quantumjim
changed the title
|
I have done some linting and added a tutorial and a test. Travis is not happy for reasons I don't understand. If anyone knows what that error is, let me know. |
|
The commenting looks a little different than the qiskit standard, see, e.g. https://github.com/Qiskit/qiskit-terra/blob/3bf6a0e5acae280910be0d7c5b24618a26461e1e/qiskit/result/result.py#L56 |
|
Based on the notebook it looks like circuits could use a |
| self.circuit[log].add_register(self.code_bit) | ||
| self.circuit[log].measure(self.code_qubit, self.code_bit) | ||
|
|
||
| def process_results(self, raw_results): |
There was a problem hiding this comment.
The philosophy is to have anything processing results be in the fitter
|
Thanks Dave. I'll fix all. |
|
error correction probably merits its own folder separate from verification? |
There's no real error correction. Read @quantumjim 's summary at the top. |
|
Looks like the build error seemed to start when I merged master, which is odd. Not sure what steps to take to fix it, but I'll look into it next week. Edit: Seems that time heals all build errors. |
The topological_code fitters module relies on networkx and has had a hard dependency on it since it was first introduced in qiskit-community#211. However, it was never added to the requirements list. This was never caught because historically qiskit-terra (which is in the requirements list) has required networkx too so installing qiskit-terra would install networkx. But, in Qiskit/qiskit#5183 the dependency on networkx was removed from terra. This commit corrects the issue so that we're properly listing networkx as an ignis requirement moving forward. Longer term we should migrate the topological codes fitter to use retworkx for better performance and consistency with the rest of Qiskit. However, before we can do that Qiskit/rustworkx#216 must be fixed first.
The topological_code fitters module relies on networkx and has had a hard dependency on it since it was first introduced in #211. However, it was never added to the requirements list. This was never caught because historically qiskit-terra (which is in the requirements list) has required networkx too so installing qiskit-terra would install networkx. But, in Qiskit/qiskit#5183 the dependency on networkx was removed from terra. This commit corrects the issue so that we're properly listing networkx as an ignis requirement moving forward. Longer term we should migrate the topological codes fitter to use retworkx for better performance and consistency with the rest of Qiskit. However, before we can do that Qiskit/rustworkx#216 must be fixed first.
The topological_code fitters module relies on networkx and has had a hard dependency on it since it was first introduced in qiskit-community#211. However, it was never added to the requirements list. This was never caught because historically qiskit-terra (which is in the requirements list) has required networkx too so installing qiskit-terra would install networkx. But, in Qiskit/qiskit#5183 the dependency on networkx was removed from terra. This commit corrects the issue so that we're properly listing networkx as an ignis requirement moving forward. Longer term we should migrate the topological codes fitter to use retworkx for better performance and consistency with the rest of Qiskit. However, before we can do that Qiskit/rustworkx#216 must be fixed first. (cherry picked from commit 2775689)
Summary
A module has been added to 'verification' to create and decode repetition codes. The 'GraphDecoder' defined in this module will be extended to surface codes, color codes and other 2D topological codes. The module has therefore been name 'topological codes'
The purpose of codes in this module is not to actually perform useful error correction, but to provide tests that are based on error correction.
Details and comments
Merging of this closes #210