This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Fix azure pipelines #430
Merged
Fix azure pipelines #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In qiskit-community#422 the azure pipelines jobs were updated to simplify the dependency installation to no longer require build scs against openblas. However there was a bug in that which caused the jobs to not really run, but still return success. This commit corrects the oversight so we're still running CI for windows and actually testing it.
|
This was already fixed on stable in: #427 |
chriseclectic
approved these changes
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #422 the azure pipelines jobs were updated to simplify the dependency
installation to no longer require build scs against openblas. However
there was a bug in that which caused the jobs to not really run, but
still return success. This commit corrects the oversight so we're still
running CI for windows and actually testing it.
Details and comments