This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 160
Small fixes for GST and entanglement api docs #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShellyGarion
previously approved these changes
Sep 13, 2020
2 tasks
gadial
changed the title
Small fixes for GST api docs
[WIP] Small fixes for GST api docs
Sep 13, 2020
gadial
changed the title
[WIP] Small fixes for GST api docs
[WIP] Small fixes for GST and entanglement api docs
Sep 13, 2020
gadial
changed the title
[WIP] Small fixes for GST and entanglement api docs
Small fixes for GST and entanglement api docs
Sep 14, 2020
close #470 |
ShellyGarion
previously approved these changes
Sep 14, 2020
mtreinish
reviewed
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the most part, just some small inline comments of things we should clean up before merging this
mtreinish
approved these changes
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments
Closes #470