This repository has been archived by the owner on Sep 13, 2019. It is now read-only.
remove init script from package.json #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the init script which was required for @qiskit/qasm 0.9.0 where qelib.inc was not included in the published modules. With the next release this will be fixed and the example should work standalone. Fixes: qiskit-community#86
@jesusprubio I'd be happy to do a release if you are alright with that (might be good to be able to do releases so in the future if you are not available for some reason). I think I'd need to be added as a collaborator to qiskit-js and if you can give me some instructions on how you normally do releases. My npm user name is |
|
Sure! Good idea. You should already have an invitation in your inbox. The steps I use:
I think I´m not forgetting anything 😄 |
Great, thanks for that! :) I hope to take a closer look at this tomorrow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove init script from package.json
Details and comments
This commit removes the init script which was required for @qiskit/qasm
0.9.0 where
qelib.incwas not included in the published modules. Withthe next release this will be fixed and the example should work
standalone.
Fixes: #86
@jesusprubio Could we do a release?