Improve unit test temp file usage (#696)

qiskit-community · Oct 5, 2023 · fe0a8f3 · fe0a8f3
1 parent 7f122be
commit fe0a8f3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/test/algorithms/regressors/test_fidelity_quantum_kernel_qsvr.py b/test/algorithms/regressors/test_fidelity_quantum_kernel_qsvr.py
@@ -106,9 +106,10 @@ def test_save_load(self):
         original_predicts = regressor.predict(test_features)
 
         # save/load, change the quantum instance and check if predicted values are the same
-        file_name = os.path.join(tempfile.gettempdir(), "qsvr.model")
-        regressor.save(file_name)
-        try:
+        with tempfile.TemporaryDirectory() as dir_name:
+            file_name = os.path.join(dir_name, "qsvr.model")
+            regressor.save(file_name)
+
             regressor_load = QSVR.load(file_name)
             loaded_model_predicts = regressor_load.predict(test_features)
 
@@ -123,9 +124,6 @@ class FakeModel(SerializableModelMixin):
             with self.assertRaises(TypeError):
                 FakeModel.load(file_name)
 
-        finally:
-            os.remove(file_name)
-
 
 if __name__ == "__main__":
     unittest.main()
diff --git a/test/algorithms/regressors/test_qsvr.py b/test/algorithms/regressors/test_qsvr.py
@@ -105,9 +105,10 @@ def test_save_load(self):
         original_predicts = regressor.predict(test_features)
 
         # save/load, change the quantum instance and check if predicted values are the same
-        file_name = os.path.join(tempfile.gettempdir(), "qsvr.model")
-        regressor.save(file_name)
-        try:
+        with tempfile.TemporaryDirectory() as dir_name:
+            file_name = os.path.join(dir_name, "qsvr.model")
+            regressor.save(file_name)
+
             regressor_load = QSVR.load(file_name)
             loaded_model_predicts = regressor_load.predict(test_features)
 
@@ -122,9 +123,6 @@ class FakeModel(SerializableModelMixin):
             with self.assertRaises(TypeError):
                 FakeModel.load(file_name)
 
-        finally:
-            os.remove(file_name)
-
 
 if __name__ == "__main__":
     unittest.main()