Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of callable as an optimizer #540

Merged
merged 13 commits into from
Dec 14, 2022
Merged

Add support of callable as an optimizer #540

merged 13 commits into from
Dec 14, 2022

Conversation

adekusar-drl
Copy link
Collaborator

Summary

This PR enables support of callable as an optimizer in the QML models and QuantumKernelTrainer.
Closed #367. Similar to Qiskit/qiskit#7191.

Details and comments

Updated algorithms:

  • NeuralNetworkClassifier
  • NeuralNetworkRegressor
  • VQC
  • VQR
  • QuantumKernelTrainer

@coveralls
Copy link

coveralls commented Dec 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3698260625

  • 31 of 31 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 90.718%
Totals Coverage Status
Change from base Build 3661802003: 0.03%
Covered Lines: 3372
Relevant Lines: 3717
💛 - Coveralls

adekusar-drl and others added 2 commits December 8, 2022 16:44
@adekusar-drl
Merge branch 'main' into callable_optimizers
d75591b
@adekusar-drl
Merge branch 'main' of https://github.com/Qiskit/qiskit-machine-learning
7a9cc62 
 into callable_optimizers

� Conflicts:
�	test/kernels/algorithms/test_qkernel_trainer.py
@adekusar-drl adekusar-drl added this to the 0.6.0 milestone Dec 14, 2022
woodsp-ibm
woodsp-ibm previously approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adekusar-drl adekusar-drl merged commit a280163 into qiskit-community:main Dec 14, 2022
@adekusar-drl adekusar-drl deleted the callable_optimizers branch December 14, 2022 23:07
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
@adekusar-drl
Add support of callable as an optimizer (#540)
e92f059 
* update classifiers

* extract common code

* update qkt

* simplify tests

* fix spell

* remove unused code

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

@manoelmarques manoelmarques Awaiting requested review from manoelmarques

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Enhance optimizer support as per recent VQE/QAOA change
3 participants
@adekusar-drl @coveralls @woodsp-ibm