-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code #690
Remove deprecated code #690
Conversation
Pull Request Test Coverage Report for Build 6224938528
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks fine to me. Since its closing the issue, and since it dealt with all the task items listed there I checked them all off in the issue.
One comment I will make, since it had to be changed (well only the format not the content) is the 0..5 migration guide. The classes, like the older QNNs and QuantumKernel often are linked, and these presently do work, but will no longer do so once the new docs, with this guide, are republished. Same is true of older release notes too of course where the same may happen. In the case of the guide there are lot of links though.
The problem with links is that we don't keep documentation for all versions. If we could have all releases, then we would be able to keep them correct. |
Though in this case they are all absolute links so it would not help - in principle yes! |
Surely, we would have to include something like |
Unless they were all relative urls so once you navigated to whatever version folder they were copied to, once they were no longer the current version, they would all still work. Anyway something for the future if/when versions of docs ever happen |
* remove old qnns * remove old kernel * remove warning filtration * fix tests * fix style * replace migration notebook with rst * update reno * skip statevector test on macos * remove sampling neural network * remove deprecations * new tests * new tests * fix stestr * replace bind_parameters with assign_parameters * remove stestr fix
Summary
This PR removes:
CircuitQNN
EstimatorQNN
TwoLayerQNN
QuantumKernel
Fixes #686