Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #690

Merged
merged 15 commits into from
Sep 18, 2023

Conversation

adekusar-drl
Copy link
Collaborator

@adekusar-drl adekusar-drl commented Sep 14, 2023

Summary

This PR removes:

  • CircuitQNN
  • EstimatorQNN
  • TwoLayerQNN
  • QuantumKernel
  • All opflow related code

Fixes #686

@coveralls
Copy link

coveralls commented Sep 15, 2023

Pull Request Test Coverage Report for Build 6224938528

  • 7 of 7 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.685%

Totals Coverage Status
Change from base Build 6162917097: -0.2%
Covered Lines: 1850
Relevant Lines: 1996

💛 - Coveralls

@adekusar-drl adekusar-drl changed the title [WIP] Remove deprecated code Remove deprecated code Sep 18, 2023
@adekusar-drl adekusar-drl marked this pull request as ready for review September 18, 2023 10:37
constraints.txt Outdated Show resolved Hide resolved
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks fine to me. Since its closing the issue, and since it dealt with all the task items listed there I checked them all off in the issue.

One comment I will make, since it had to be changed (well only the format not the content) is the 0..5 migration guide. The classes, like the older QNNs and QuantumKernel often are linked, and these presently do work, but will no longer do so once the new docs, with this guide, are republished. Same is true of older release notes too of course where the same may happen. In the case of the guide there are lot of links though.

@adekusar-drl
Copy link
Collaborator Author

The problem with links is that we don't keep documentation for all versions. If we could have all releases, then we would be able to keep them correct.

@adekusar-drl adekusar-drl merged commit 5bdbc01 into qiskit-community:main Sep 18, 2023
13 checks passed
@adekusar-drl adekusar-drl deleted the remove-deprecated branch September 18, 2023 16:30
@woodsp-ibm
Copy link
Member

Though in this case they are all absolute links so it would not help - in principle yes!

@adekusar-drl
Copy link
Collaborator Author

Surely, we would have to include something like /0.5/ in urls.

@woodsp-ibm
Copy link
Member

Unless they were all relative urls so once you navigated to whatever version folder they were copied to, once they were no longer the current version, they would all still work. Anyway something for the future if/when versions of docs ever happen

oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
* remove old qnns

* remove old kernel

* remove warning filtration

* fix tests

* fix style

* replace migration notebook with rst

* update reno

* skip statevector test on macos

* remove sampling neural network

* remove deprecations

* new tests

* new tests

* fix stestr

* replace bind_parameters with assign_parameters

* remove stestr fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all deprecated code
3 participants